feat: Reimplement the Zooming Image Tool [Sumac backport] #36027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Zooming Image Tool does not load properly, currently, and even if it did, relying on an external Javascript to function across releases is not something we can support. Thus, we remove it from the list of HTML block templates until such time as a more robust solution is found.
This recreates the Zooming Image Tool template for the HTML block. It does it in such a way that doesn't depend on any external resources: both the loupe code and sample image are inlined. Some benefits to this version are: * We can now maintain the loupe javascript code properly * Because the javascript is included in the contents of the block itself, the course author can customize it as needed * As opposed to the previous iteration, the magnified image URL is now optional: if it's not present, the regular image will be used for magnification * There can now be two or more instances of the tool in the same unit. This also removes some CSS left over from the previous iteration.
arbrandes
changed the title
pdpinch
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
you rock @arbrandes
I was just surprised by the changes to test_block.py. That wasn't part of master PR #36012 was it?
| ) | ||
| self.assertEqual(resp.status_code, 200) | ||
| html, __ = self._get_container_preview(split_test_usage_key) | ||
| self.assertIn("Announcement", html) | ||
| self.assertIn("Zooming", html) | ||
| self.assertIn("LaTeX", html) |
There was a problem hiding this comment.
The test suite for these templates just randomly included some of them (and not others). When removing the tool originally, I just added another random one. 🤷🏼
mariajgrimaldi
approved these changes
Dec 13, 2024
arbrandes
merged commit bc17b35
into
openedx:open-release/sumac.master
48 checks passed
|
@pdpinch, the changes were part of the original removal PR, which got included here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #36012 to Sumac.
Description
This recreates the Zooming Image Tool template for the HTML block. It does it in such a way that doesn't depend on any external resources: both the loupe code and sample image are inlined.
Some benefits to this version are:
We can now maintain the loupe javascript code properly
Because the javascript is included in the contents of the block itself, the course author can customize it as needed
As opposed to the previous iteration, the magnified image URL is now optional: if it's not present, the regular image will be used for magnification
There can now be two or more instances of the tool in the same unit.